Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2313#discussion_r188906834
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
 ---
    @@ -282,12 +282,15 @@ private void readIndexFile(CarbonFile indexFile) 
throws IOException {
         DataInputStream dataInputStream =
             FileFactory.getDataInputStream(indexFilePath, 
FileFactory.getFileType(indexFilePath));
         byte[] bytes = new byte[(int) indexFile.getSize()];
    -    dataInputStream.readFully(bytes);
    -    carbonIndexMap.put(indexFile.getName(), bytes);
    -    carbonIndexMapWithFullPath.put(
    -        indexFile.getParentFile().getAbsolutePath() + 
CarbonCommonConstants.FILE_SEPARATOR
    -            + indexFile.getName(), bytes);
    -    dataInputStream.close();
    +    try {
    --- End diff --
    
    Finally should have only close


---

Reply via email to