Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189175211
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java
---
@@ -115,23 +115,26 @@ public void setDetailInfo(BlockletDetailInfo
blockletDetailInfo) {
}
- public static CarbonInputSplit convertSplit(CarbonLocalInputSplit
carbonLocalInputSplit) {
+ public static CarbonInputSplit convertSplit(CarbonLocalInputSplit
carbonLocalInputSplit) {
CarbonInputSplit inputSplit = new
CarbonInputSplit(carbonLocalInputSplit.getSegmentId(), "0",
new Path(carbonLocalInputSplit.getPath()),
carbonLocalInputSplit.getStart(),
carbonLocalInputSplit.getLength(),
carbonLocalInputSplit.getLocations()
.toArray(new String[carbonLocalInputSplit.getLocations().size()]),
- carbonLocalInputSplit.getNumberOfBlocklets(),
ColumnarFormatVersion.valueOf(carbonLocalInputSplit.getVersion()),
+ carbonLocalInputSplit.getNumberOfBlocklets(),
+ ColumnarFormatVersion.valueOf(carbonLocalInputSplit.getVersion()),
carbonLocalInputSplit.getDeleteDeltaFiles());
Gson gson = new Gson();
- BlockletDetailInfo blockletDetailInfo =
gson.fromJson(carbonLocalInputSplit.detailInfo, BlockletDetailInfo.class);
- try {
-
blockletDetailInfo.readColumnSchema(blockletDetailInfo.getColumnSchemaBinary());
- } catch (IOException e) {
- throw new RuntimeException(e);
+ BlockletDetailInfo blockletDetailInfo =
+ gson.fromJson(carbonLocalInputSplit.detailInfo,
BlockletDetailInfo.class);
+
+ if (null != blockletDetailInfo) {
--- End diff --
blockletDetailInfo null case should throw exception
---
