[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r227619046
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java
 ---
    @@ -198,4 +219,48 @@ void fillColumnVectorDetails(CarbonColumnarBatch 
columnarBatch, int rowCounter,
         }
       }
     
    +  private void collectResultInColumnarBatchDirect(BlockletScannedResult 
scannedResult,
    --- End diff --
    
    add comment for this function


---