[
https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240158#comment-15240158
]
Gilles commented on MATH-1290:
------------------------------
bq. That sounds encouraging.
What is not encouraging is that I still did not get your latest changes.
This command, suggested a few comments back
{noformat}
git pull https://github.com/ericbarnhill/commons-math.git feature-MATH-1290
{noformat}
does not pull anything!
I'd be most interested to see a command session similar to what I did with the
commons-lang PR, showing that it brings commits of yours on top of what is
currently in "origin/feature-MATH-1290".
Again, I never used "Github", so I cannot possibly imagine whether something
might going wrong with it (e.g. the mirroring of the Apache repository or
anything). Is it possible for you to try and make the PR not through "Github"?
If not, then a patch will be fine (provided it is a diff wrt branch
"feature-MATH-1290").
> Additions to Complex Utils; creation of conversion methods between Complex[],
> double[], float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-1290
> URL: https://issues.apache.org/jira/browse/MATH-1290
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.5
> Reporter: Eric Barnhill
> Priority: Minor
> Labels: newbie, patch
> Fix For: 4.0
>
> Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
> ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
> ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy
> conversion between Complex[] arrays, real or imaginary double[] or float[]
> arrays, and interleaved complex double[] or float[] arrays. The last two in
> particular are beneficial to have for OpenCL implementations and the
> JTransforms library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
