[
https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247471#comment-15247471
]
Gilles commented on MATH-1290:
------------------------------
When a large numbers of changes is involved, it is all the more useful to
separate categories of changes (e.g. formatting vs semantics) and indicate
which is which in the log.
For example, your request contains commits that change the Javadoc, but I also
see several occurrences of this kind of change:
{noformat}
- TestUtils.assertEquals(msg, ansArrayc1r, ComplexUtils.real2Complex(f,
range1),Math.ulp(1.0));
+ TestUtils.assertEquals(msg, ansArrayc1r, ComplexUtils.real2Complex(f,
range1), Math.ulp(1));
{noformat}
Here the test tolerance has been dramatically changed, which is either a
mistake or its reason must be spelled out unequivocally.
> Additions to Complex Utils; creation of conversion methods between Complex[],
> double[], float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-1290
> URL: https://issues.apache.org/jira/browse/MATH-1290
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.5
> Reporter: Eric Barnhill
> Priority: Minor
> Labels: newbie, patch
> Fix For: 4.0
>
> Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
> ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
> ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy
> conversion between Complex[] arrays, real or imaginary double[] or float[]
> arrays, and interleaved complex double[] or float[] arrays. The last two in
> particular are beneficial to have for OpenCL implementations and the
> JTransforms library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
