[
https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246752#comment-15246752
]
Gilles commented on MATH-1290:
------------------------------
Hi Eric.
The command
{noformat}
git pull https://github.com/ericbarnhill/commons-math.git feature-MATH-1290
{noformat}
did pull something this time! We are making progress. ;)
However, files have been changed that should not have been:
{noformat}
$ git diff --name-only origin/feature-MATH-1290
src/main/java/org/apache/commons/math4/analysis/interpolation/AkimaSplineInterpolator.java
src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialSplineFunction.java
src/main/java/org/apache/commons/math4/complex/ComplexUtils.java
src/test/java/org/apache/commons/math4/TestUtils.java
src/test/java/org/apache/commons/math4/complex/ComplexUtilsTest.java
{noformat}
Moreover, the commit log is not really helpful:
{noformat}
commit 2df243026fcab4010afc10468bb6ab8ce42aa2ad
Merge: 02e4f6b f0203ef
Author: Eric Barnhill <[email protected]>
Date: Mon Apr 11 23:29:46 2016 +0200
merging barnhill-1290 into feature-MATH-1290
commit f0203efe747de9b845a836c17328ae61e1c58de8
Author: Eric Barnhill <[email protected]>
Date: Mon Apr 11 23:21:00 2016 +0200
Barnhill changes to feature-MATH-1290
commit 6abc4ddede31124f95eecd11784b00ed3ac0baf9
Author: Eric Barnhill <[email protected]>
Date: Mon Apr 11 23:20:24 2016 +0200
Previous Changes
{noformat}
The log need not be a detailed account of every change but it should summarize
the purpose of the modifications.
E.g. changes that only touched the Javadoc comments can be summarized as just
"Javadoc"; simply mentioning "Formatting" is also fine if that's the case.
Figuring out a meaningful log message could be construed as annoying but it is
quite useful to help reviewers understand why and how things changed. In this
case, in particular, the changes to
{noformat}
src/main/java/org/apache/commons/math4/analysis/interpolation/AkimaSplineInterpolator.java
src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialSplineFunction.java
{noformat}
are totally unexpected.
I also seem to see other duplicates from previous commits, unrelated to this
feature. Maybe this is because at some point you had continued to update the
"wrong" branch. So for this time, let's fix things with plain patches...
> Additions to Complex Utils; creation of conversion methods between Complex[],
> double[], float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-1290
> URL: https://issues.apache.org/jira/browse/MATH-1290
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.5
> Reporter: Eric Barnhill
> Priority: Minor
> Labels: newbie, patch
> Fix For: 4.0
>
> Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
> ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
> ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy
> conversion between Complex[] arrays, real or imaginary double[] or float[]
> arrays, and interleaved complex double[] or float[] arrays. The last two in
> particular are beneficial to have for OpenCL implementations and the
> JTransforms library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
