[
https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=200428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200428
]
ASF GitHub Bot logged work on TEXT-104:
---------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 09:51
Start Date: 19/Feb/19 09:51
Worklog Time Spent: 10m
Work Description: kinow commented on issue #100: TEXT-104: Jaro Winkler
Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-465063138
HI @saschaszott ! Thanks for updating it so quickly! Only had time to look
at it now (almost bed time). Will review it tomorrow with more calm, but looks
good to me after a brief view. I think it may be merged tomorrow unless I find
anything missing (which I don't believe I will!).
Will update `changes.xml` later and see when we can cut a release.
Cheers
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200428)
Time Spent: 1.5h (was: 1h 20m)
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Priority: Trivial
> Fix For: 2.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
