[
https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=202463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202463
]
ASF GitHub Bot logged work on TEXT-104:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 09:11
Start Date: 22/Feb/19 09:11
Worklog Time Spent: 10m
Work Description: kinow commented on issue #102: TEXT-104: deprecate
JaroWinkler methods for 2.0, and fix clirr report
URL: https://github.com/apache/commons-text/pull/102#issuecomment-466327585
Tested on Oracle Java 8, and Open JDK 11 with `mvn
-Dcheckstyle.failOnViolation=false`, all tests, reports (except checkstyle),
and javadoc passed OK. If no objections will merge over the weekend. Had a look
at Clirr as well, only 6 infos, no errors and no warnings :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202463)
Time Spent: 3h (was: 2h 50m)
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Assignee: Bruno P. Kinoshita
> Priority: Trivial
> Fix For: 1.7
>
> Attachments: image-2019-02-20-20-32-41-512.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
