[
https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=201806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201806
]
ASF GitHub Bot logged work on TEXT-104:
---------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/19 08:33
Start Date: 21/Feb/19 08:33
Worklog Time Spent: 10m
Work Description: jmkeil commented on issue #102: TEXT-104: deprecate
JaroWinkler methods for 2.0, and fix clirr report
URL: https://github.com/apache/commons-text/pull/102#issuecomment-465908787
The magic numbers probably could be resolved by adding:
```java
private final static int COMMON_PREFIX_LENGTH_LIMIT = 4;
private final static double BOOST_THRESHOLD = 0.7d;
```
I think, it would be better to deprecate the whole class instead of the
methods. Is there any reason to duplicate the code and not use the class
`JaroWinklerSimilarity`? What about:
```java
/**
* @deprecated Deprecated as of 1.7. This Class will be removed in 2.0 and
replaced by the class {@link JaroWinklerSimilarity}, as it implemented a
similarity measure instead of a distance measure.
*/
@Deprecated
public class JaroWinklerDistance extends JaroWinklerSimilarity {}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201806)
Time Spent: 2h 40m (was: 2.5h)
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Assignee: Bruno P. Kinoshita
> Priority: Trivial
> Fix For: 1.7
>
> Attachments: image-2019-02-20-20-32-41-512.png
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
