[
https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=201633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201633
]
ASF GitHub Bot logged work on TEXT-104:
---------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 21:51
Start Date: 20/Feb/19 21:51
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #102: TEXT-104:
deprecate JaroWinkler methods for 2.0, and fix clirr report
URL: https://github.com/apache/commons-text/pull/102
This PR makes the Clirr report pass for 1.7. It keeps the new
`JaroWinklerSimilarity` class, but reverts the change in `JaroWinklerDistance`.
This way we keep backward feature and binary compatibility.
Also added `TODO`'s in the code for 2.0, and if others are OK with this pull
request, I will create a Task ticket in JIRA for 2.0, so that when a release
manager performs the release, s/he won't forget to look at the TODO and update
the code.
@saschaszott I feel bad reverting part of your change, but it will be fully
available in an upcoming 2.0 release :)
Cheers
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201633)
Time Spent: 2h (was: 1h 50m)
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Assignee: Bruno P. Kinoshita
> Priority: Trivial
> Fix For: 1.7
>
> Attachments: image-2019-02-20-20-32-41-512.png
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
