[
https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=201817&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201817
]
ASF GitHub Bot logged work on TEXT-104:
---------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/19 08:55
Start Date: 21/Feb/19 08:55
Worklog Time Spent: 10m
Work Description: kinow commented on issue #102: TEXT-104: deprecate
JaroWinkler methods for 2.0, and fix clirr report
URL: https://github.com/apache/commons-text/pull/102#issuecomment-465915589
>The magic numbers probably could be resolved by adding:
I am not sure if Checkstyle issues are a blocker for a release. I don't
think so (and they would be fixed in 2.0). I am more concerned that they seem
to have stopped the build of progressing. I believe we have Javadocs issues
from master, before I merged the pull request.
>I think, it would be better to deprecate the whole class instead of the
methods. Is there any reason to duplicate the code and not use the class
`JaroWinklerSimilarity`? What about:
@jmkeil but in this case we would drop the edit distance, and have only the
similarity (I believe it would be better to have both, for consistency).
What was implemented in the other pull request is similar to the other edit
distance & similarity scores we already have (just fixing jaro winkler). And is
also similar to what we can use in [other Java
libraries](https://github.com/tdebatty/java-string-similarity#jaro-winkler) or
with
[JS](https://github.com/Yomguithereal/talisman/blob/51756b23cfd7e32c61f11c2f5a31f6396d15812a/src/metrics/distance/jaro.js#L108),
[Python](https://github.com/nap/jaro-winkler-distance/blob/835bede1913232a8255c9e18533c430989c55bde/pyjarowinkler/distance.py#L32),
etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201817)
Time Spent: 2h 50m (was: 2h 40m)
> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Assignee: Bruno P. Kinoshita
> Priority: Trivial
> Fix For: 1.7
>
> Attachments: image-2019-02-20-20-32-41-512.png
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The 'apply' method returns the similarity score instead of the distance score
> as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the
> rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
