[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254265#comment-15254265
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213519895
@ktop I did a quick test of this with one of my existing apps and it does
add the following lines to AndroidManifest.xml:
```
<application android:isGame="true" android:name="MyApplication" />
<uses-sdk android:maxSdkVersion="22" />
```
but unfortunately it already had the following lines:
```
<application android:hardwareAccelerated="true"
android:icon="@drawable/icon" android:label="@string/app_name"
android:supportsRtl="true">
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="23" />
```
So in order for this to get merged it has to be able to modify existing
lines instead of adding new ones.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
