[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262396#comment-15262396
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215478064
## [Current coverage][cc-pull] is **79.60%**
> Merging [#432][cc-pull] into [master][cc-base-branch] will increase
coverage by **-0.49%**
```diff
@@ master #432 diff @@
========================================
Files 69 69
Lines 5029 5398 +369
Methods 0 865 +865
Branches 972 1017 +45
========================================
+ Hits 4029 4297 +268
- Misses 995 1101 +106
+ Partials 5 0 -5
```
1. 4 files in `...dova-lib/src/cordova` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F7661)
- Misses `+1`
- Hits `+13`
1. 2 files (not in diff) in `...lib/src/util/windows` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F7574696C2F77696E646F7773)
- Misses `+6`
- Partials `-1`
- Hits `+24`
1. 2 files (not in diff) in `cordova-lib/src/util` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F7574696C)
- Misses `+4`
- Hits `+1`
1. 5 files (not in diff) in `...lib/src/plugman/util` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F706C75676D616E2F7574696C)
- Misses `-1`
- Hits `+17`
1. 7 files (not in diff) in `...rc/plugman/platforms` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F706C75676D616E2F706C6174666F726D73)
- Misses `+32`
- Hits `+63`
1. 7 files (not in diff) in `...dova-lib/src/plugman` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F706C75676D616E)
- Misses `+22`
- Hits `+36`
1. 3 files (not in diff) in `...ordova-lib/src/hooks` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F686F6F6B73)
- Misses `+2`
- Hits `+2`
1. 9 files (not in diff) in `...src/cordova/metadata` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F76612F6D65746164617461)
- Misses `+3`
- Hits `+12`
1. 10 files (not in diff) in `...dova-lib/src/cordova` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F7661)
- Misses `+31`
- Partials `-2`
- Hits `+78`
1. 2 files (not in diff) in `cordova-lib/src` were modified.
[more](https://codecov.io/gh/apache/cordova-lib/commit/352d71395621245f691ec6143290ccd7774cbae9/changes?src=pr#636F72646F76612D6C69622F737263)
- Misses `+6`
- Partials `-2`
- Hits `+18`
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 352d713
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/432?src=pr
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
