[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264652#comment-15264652
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756
@ktop config-file wasn't in config.xml before, but we wanted to add it
because the number of config.xml attributes that just edit various native xml
files is getting unsustainable. I think that config.xml's config-file
modifications should happen during the same step as the plugins' modifications
do, but they should definitely be applied after all of the plugin.xml ones.
That way, the app developer always has the option to override whatever the
plugins are doing.
I think the mode flag is a good idea, but I worry about allowing it in
plugin.xml. If plugins are able to do things other than add elements, does that
mean we have the opportunity for plugins to overwrite each other's
modifications depending on the order in which their config-file attributes are
resolved? That might get weird. Definitely makes sense to have it in config.xml
though.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
