[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268781#comment-15268781
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951
@purplecabbage
My workspace is working off of the master branches with the tools npm
linked.
I modified the plugin.xml of cordova-plugin-device and added:
```
<config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
<application android:name="MyApplication" android:isGame="true" />
<uses-sdk android:maxSdkVersion="22" />
</config-file>
```
Then for the project:
```
cordova create myApp
cd myApp
cordova platform add ../cordova-android
cordova plugin add ../cordova-plugin-device
```
I check AndroidManifest.xml and the new attributes are there as expect,
without a new tag being added.
I'll try testing this PR on another machine and see what result I get.
As for getting config-file tag into config.xml, I've been caught up in some
other work so will get to this sometime later in the week.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
