[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264617#comment-15264617
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823
@macdonst
I had Edna test the first time around before I opened the PR and she was
able to get it working, so that is weird that it is adding a new element for
you.
Was config-file functional in config.xml before? Or was that something to
be done as part of this jira issue? I was only focused on getting it working in
plugin.xml, so I can work on it if it isn't implemented yet. Should config.xml
handle config-file during prepare?
The mode suggestion sounds good. It will give users a lot of utility for
modifying xml files.
I have just few clarification questions:
- If no mode is specified, is the default to add?
- For replace, if there is nothing to replace, should it still try to add?
- And for delete, should it delete an element even if the element has
children?
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
