[ https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151191#comment-16151191 ]
ASF GitHub Bot commented on DRILL-5723: --------------------------------------- Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136669723 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -70,11 +69,13 @@ * </p> */ -public class SystemOptionManager extends BaseOptionManager implements OptionManager, AutoCloseable { +public class SystemOptionManager extends BaseOptionManager implements AutoCloseable { private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(SystemOptionManager.class); - private CaseInsensitiveMap<OptionValidator> VALIDATORS; - public void populateValidators() { + public static final CaseInsensitiveMap<OptionValidator> DEFAULT_VALIDATORS = --- End diff -- I don't completely follow this. Let's talk about this offline next week so that I can understand :). I can post the conclusion of the discussion on the PR for the community then. > Support System/Session Internal Options > --------------------------------------- > > Key: DRILL-5723 > URL: https://issues.apache.org/jira/browse/DRILL-5723 > Project: Apache Drill > Issue Type: New Feature > Reporter: Timothy Farkas > Assignee: Timothy Farkas > > This is a feature proposed by [~ben-zvi]. > Currently all the options are accessible by the user in sys.options. We would > like to add internal options which can be altered, but are not visible in the > sys.options table. These internal options could be seen by another alias > select * from internal.options. The intention would be to put new options we > weren't comfortable with exposing to the end user in this table. > After the options and their corresponding features are considered stable they > could be changed to appear in the sys.option table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)