[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154371#comment-16154371
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r137122952
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -83,18 +86,20 @@
@VisibleForTesting
public Drillbit(
final DrillConfig config,
+ final CaseInsensitiveMap<OptionValidator> validators,
final RemoteServiceSet serviceSet) throws Exception {
- this(config, serviceSet, ClassPathScanner.fromPrescan(config));
+ this(config, validators, serviceSet,
ClassPathScanner.fromPrescan(config));
--- End diff --
Currently there are no internal validators defined, so in order to test the
logic for internal validators I had to create a set of mock validators which
included internal validators, and use those for testing. I have changed this so
that the Drillbit constructors which take a set of validators are annotated to
be visible for testing.
> Support System/Session Internal Options
> ---------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
