[
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010213#comment-16010213
]
ASF GitHub Bot commented on FLINK-6462:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116444166
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -31,6 +31,18 @@ class WindowAggregateTest extends TableTestBase {
streamUtil.addTable[(Int, String, Long)](
"MyTable", 'a, 'b, 'c, 'proctime.proctime, 'rowtime.rowtime)
+ /**
+ * OVER clause is necessary for [[OverAgg0]] window function.
+ */
+ @Test(expected = classOf[ValidationException])
+ def testOverAggregation() = {
+ streamUtil.addFunction("overAgg", new OverAgg0)
+
+ val sqlQuery = "SELECT overAgg(c, a) FROM MyTable"
+
+ streamUtil.verifySql(sqlQuery, "n/a")
--- End diff --
`streamUtil.tEnv.sql(sqlQuery)` is sufficient. We do not need to call the
optimizer.
> Add requiresOver interface for AggregateFunction
> -------------------------------------------------
>
> Key: FLINK-6462
> URL: https://issues.apache.org/jira/browse/FLINK-6462
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window,
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using
> `requiresOver` to distinguish.
> In this JIRA. will deal with this feature.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
