[ 
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010211#comment-16010211
 ] 

ASF GitHub Bot commented on FLINK-6462:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3851#discussion_r116443377
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupWindowTest.scala
 ---
    @@ -30,6 +30,23 @@ import org.junit.{Ignore, Test}
     
     class GroupWindowTest extends TableTestBase {
     
    +  /**
    +    * OVER clause is necessary for [[OverAgg0]] window function.
    +    */
    +  @Test(expected = classOf[TableException])
    +  def testOverAggregation(): Unit = {
    +    val util = streamTestUtil()
    +    val table = util.addTable[(Long, Int, String)]('long, 'int, 'string, 
'proctime.proctime)
    +
    +    val overAgg = new OverAgg0
    +    val windowedTable = table
    +      .window(Tumble over 2.rows on 'proctime as 'w)
    +      .groupBy('w, 'string)
    +      .select(overAgg('long, 'int))
    +
    +    util.verifyTable(windowedTable, "n/a")
    --- End diff --
    
    When the check is done in validation phase, we do not have to call 
`verifyTable()` (same for all other Table API tests).


> Add requiresOver interface for  AggregateFunction
> -------------------------------------------------
>
>                 Key: FLINK-6462
>                 URL: https://issues.apache.org/jira/browse/FLINK-6462
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>             Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window, 
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do 
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined 
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using 
> `requiresOver` to distinguish. 
> In this JIRA. will deal with this feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to