[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011298#comment-16011298 ]
ASF GitHub Bot commented on FLINK-6462: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116595446 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/validation/AggregationsValidationTest.scala --- @@ -20,13 +20,25 @@ package org.apache.flink.table.api.scala.batch.table.validation import org.apache.flink.api.scala._ import org.apache.flink.api.scala.util.CollectionDataSets -import org.apache.flink.table.api.java.utils.UserDefinedAggFunctions.WeightedAvgWithMergeAndReset +import org.apache.flink.table.api.java.utils.UserDefinedAggFunctions.{OverAgg0, WeightedAvgWithMergeAndReset} import org.apache.flink.table.api.scala._ import org.apache.flink.table.api.{TableEnvironment, ValidationException} import org.junit._ class AggregationsValidationTest { + /** + * OVER clause is necessary for [[OverAgg0]] window function. + */ + @Test(expected = classOf[ValidationException]) + def testOverAggregation(): Unit = { + val env= ExecutionEnvironment.getExecutionEnvironment --- End diff -- +space `val env = ExecutionEnvironment...` > Add requiresOver interface for AggregateFunction > ------------------------------------------------- > > Key: FLINK-6462 > URL: https://issues.apache.org/jira/browse/FLINK-6462 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: sunjincheng > Assignee: sunjincheng > Fix For: 1.3.0 > > > The window function in the standard database only supports the "over" window, > such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do > not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined > AGG need to be clearly defined. In calcite `SqlAggFunction` will using > `requiresOver` to distinguish. > In this JIRA. will deal with this feature. -- This message was sent by Atlassian JIRA (v6.3.15#6346)