[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011299#comment-16011299 ]
ASF GitHub Bot commented on FLINK-6462: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116592899 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -215,14 +215,22 @@ case class Aggregate( } override def validate(tableEnv: TableEnvironment): LogicalNode = { - + implicit val relBuilder: RelBuilder = tableEnv.getRelBuilder val resolvedAggregate = super.validate(tableEnv).asInstanceOf[Aggregate] val groupingExprs = resolvedAggregate.groupingExpressions val aggregateExprs = resolvedAggregate.aggregateExpressions aggregateExprs.foreach(validateAggregateExpression) groupingExprs.foreach(validateGroupingExpression) def validateAggregateExpression(expr: Expression): Unit = expr match { + case Alias(child, _, _) => validateAggregateExpression(child) --- End diff -- Isn't this case caught by the last case `case e => e.children.foreach(validateAggregateExpression)`? > Add requiresOver interface for AggregateFunction > ------------------------------------------------- > > Key: FLINK-6462 > URL: https://issues.apache.org/jira/browse/FLINK-6462 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: sunjincheng > Assignee: sunjincheng > Fix For: 1.3.0 > > > The window function in the standard database only supports the "over" window, > such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do > not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined > AGG need to be clearly defined. In calcite `SqlAggFunction` will using > `requiresOver` to distinguish. > In this JIRA. will deal with this feature. -- This message was sent by Atlassian JIRA (v6.3.15#6346)