[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265700#comment-16265700
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5068
[FLINK-8122] [table] Name all built-in table sinks and sources
## What is the purpose of the change
This PR adds names for all built-in table sources and sinks.
## Brief change log
- Adds a `getRuntimeName()` method which returns a string consisting of
the class name and the field names to the `TableSource` and `TableSink` traits.
- Implements `getRuntimeName()` in all sub-sources and sub-sinks written
in **Java** (since it seems they cannot extend the implementations in scala
traits).
- Names the `DataSources` and `DataSinks` with the `getRuntimeName()`
after creating the stream operators in all built-in table sinks and sources.
- To avoid NPE, adds a mock `DataStreamSink`(`DataStreamSource`) when
invoking `Environment.addSource()` (`DataStream.addSink()`) in some existing
tests.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xccui/flink FLINK-8122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5068
----
commit c0e837dc8a581ea5479a110dbf62bfbd44681560
Author: Xingcan Cui <[email protected]>
Date: 2017-11-24T09:53:20Z
[FLINK-8122] [table] Name all built-in table sinks and sources
----
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
