[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278622#comment-16278622
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r154959996
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
---
@@ -108,11 +108,15 @@ class TestFilterableTableSource(
private val filterValues = new mutable.ArrayBuffer[Int]
override def getDataSet(execEnv: ExecutionEnvironment): DataSet[Row] = {
- execEnv.fromCollection[Row](applyPredicatesToRows(data).asJava,
getReturnType)
+ execEnv
+ .fromCollection[Row](applyPredicatesToRows(data).asJava,
getReturnType)
+ .name(explainSource())
--- End diff --
Would be great if you can be consistent with parenthesis. Sometimes it is
`explainSource()` and sometimes `explainSource`.
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
