[ 
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281721#comment-16281721
 ] 

ASF GitHub Bot commented on FLINK-8122:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r155492981
  
    --- Diff: 
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraAppendTableSink.java
 ---
    @@ -80,9 +81,15 @@ public void emitDataStream(DataStream<Row> dataStream) {
                        CassandraSink.addSink(dataStream)
                                .setClusterBuilder(this.builder)
                                .setQuery(this.cql)
    -                           .build();
    +                           .build()
    +                           .name(explainSink());
    --- End diff --
    
    Call `TableConnectorUtil.genRuntimeName(this.getClass().getSimpleName(), 
fieldNames)` directly?


> Name all table sinks and sources
> --------------------------------
>
>                 Key: FLINK-8122
>                 URL: https://issues.apache.org/jira/browse/FLINK-8122
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are 
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should 
> add names for all built-in connectors. Having information about the table 
> sink name (via {{INSERT INTO}}) would be even better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to