[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278620#comment-16278620
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r154956025
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraAppendTableSink.java
---
@@ -80,9 +81,16 @@ public void emitDataStream(DataStream<Row> dataStream) {
CassandraSink.addSink(dataStream)
.setClusterBuilder(this.builder)
.setQuery(this.cql)
- .build();
+ .build()
+ .name(explainSink());
} catch (Exception e) {
throw new RuntimeException(e);
}
}
+
+ @Override
+ public String explainSink() {
+ return getClass().getSimpleName() + " "
--- End diff --
I would move the expression to a util class because it is used for all
other sinks and sources as well. And also remove the space. Btw fieldNames can
be null if the sink is not configured. So maybe we should use something like
"CassandraAppendTableSink(*)" in this case.
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
