[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

[sunjincheng121]

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160413930
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
 ---
    @@ -145,6 +145,14 @@ class DataStreamOverAggregate(
           inputSchema.typeInfo,
           Some(constants))
     
    +    val constantsTypeInfo =
    +      
Some(constants).map(_.map(generator.generateExpression(_))).getOrElse(Seq()).map(_.resultType)
    +  val aggInputTypeInfo = constantsTypeInfo.++:(inputSchema.fieldTypeInfos)
    +
    +    val aggregateInputType =
    +      cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory]
    --- End diff --
    
    +1


---