Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160430205
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14 @@ class SetOperatorsITCase(
TestBaseUtils.compareResultAsText(results.asJava, expected)
}
+ /**
+ * This test will checks IN for NULLs based on whether COUNT (*) and
COUNT (a) are equal. Due to
+ *
[[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
will
+ * union a NULL row in to input DataSet for non-groupBy agg. That
caused COUNT (*) and COUNT(a)
+ * are not equal. So this test case ignored before FLINK-8355 be fixed.
--- End diff --
`6` times true and `9` times false is my expect.. but because
`DataSetAggregateWithNullValuesRule` we will get the `9` times `null`. as
follows:
```
expected: [false, false, false, false, false, false, false, false, false,
true, true, true, true, true, true]
received: [null, null, null, null, null, null, null, null, null, true,
true, true, true, true, true]
```
---
