Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160416641
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14 @@ class SetOperatorsITCase(
TestBaseUtils.compareResultAsText(results.asJava, expected)
}
+ /**
+ * This test will checks IN for NULLs based on whether COUNT (*) and
COUNT (a) are equal. Due to
+ *
[[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
will
+ * union a NULL row in to input DataSet for non-groupBy agg. That
caused COUNT (*) and COUNT(a)
+ * are not equal. So this test case ignored before FLINK-8355 be fixed.
--- End diff --
I think this test case is bug of batch, so we should open it after
FLINK-8355.
You are right we not sure how to fix the FLINK-8355 current time, but we
are sure add a `null` row is not correct(best) way to deal with `non-groupby`
query. But I think we should fix FLINK-8355 after this PR merged(when we know
how to fix it). What do you think?
---
