[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

[sunjincheng121]

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160426130
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
 ---
    @@ -254,7 +254,7 @@ class JoinITCase(
         val table = 
CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a1, 'a2, 'a3)
         tEnv.registerTable("A", table)
     
    -    val sqlQuery2 = "SELECT * FROM (SELECT count(*) FROM A) CROSS JOIN A"
    --- End diff --
    
    HI, @fhueske I do not think The PR breaks the correctness of the test :), 
because when we run this test case will match 
`DataSetAggregateWithNullValuesRule`. which will union a NULL  row to dataset.  
so using `COUNT(a1)` result `3` and using `COUNT(*)` result `4`. I think this 
is batch bug.  The snip as follow:
    
![image](https://user-images.githubusercontent.com/22488084/34726497-250f4b30-f58f-11e7-92cf-595f9c9a64e0.png)
 
    I think we can talk about this bug in FlINK-8355... What do you think?



---