Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160420917
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
 ---
    @@ -254,7 +254,7 @@ class JoinITCase(
         val table = 
CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a1, 'a2, 'a3)
         tEnv.registerTable("A", table)
     
    -    val sqlQuery2 = "SELECT * FROM (SELECT count(*) FROM A) CROSS JOIN A"
    --- End diff --
    
    The current result is correct. `CollectionDataSets.getSmall3TupleDataSet` 
has three rows. Hence `SELECT count(a1) FROM A` must be `3` and not `4`. 
    The PR breaks the correctness of the test.


---

Reply via email to