azagrebin commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r294229438
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartition.java
##########
@@ -93,12 +92,8 @@
/**
* Common constructor.
*/
- public BoundedBlockingSubpartition(
- int index,
- ResultPartition parent,
- Path filePath) throws IOException {
-
- this(index, parent, MemoryMappedBuffers.create(filePath));
+ BoundedBlockingSubpartition(int index, ResultPartition parent) throws
IOException {
+ this(index, parent,
MemoryMappedBuffers.create(parent.createFileChannelPath()));
Review comment:
`MemoryMappedBuffers.create(parent.createFileChannelPath())`:
I think all complicated construction logic should happen in
`ResultPartitionFactory`. `ResultPartition` should not provide convenience
methods for construction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
