azagrebin commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r294354805
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java
##########
@@ -479,6 +491,7 @@ public int hashCode() {
result = 31 * result + floatingNetworkBuffersPerGate;
result = 31 * result + (isCreditBased ? 1 : 0);
result = 31 * result + (nettyConfig != null ?
nettyConfig.hashCode() : 0);
+ result = 31 * result + tempDirs.hashCode();
Review comment:
True we can consider removal of these methods in a separate issue (we should
make sure they are not needed) but then I would prefer to keep them consistent
in this PR as long as they exist and add `tempDirs` using the proper array
methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
