azagrebin commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r295194169
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactoryTest.java
##########
@@ -50,7 +51,7 @@ public void testForceConsumptionOnReleaseDisabled() {
private static void testForceConsumptionOnRelease(boolean
forceConsumptionOnRelease) {
ResultPartitionFactory factory = new ResultPartitionFactory(
new ResultPartitionManager(),
- new NoOpIOManager(),
+ new FileChannelManager(new String[]
{EnvironmentInformation.getTemporaryFileDirectory()}),
Review comment:
we should actually close it at the end to not leak temp folders or introduce
`FileChannelManager` interface and provide testing noop implementation, also
for `ResultPartitionBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
