azagrebin commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r295187077
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -386,6 +391,9 @@ public void close() {
LOG.warn("Network buffer pool did not shut down
properly.", t);
}
+ // delete all the temp directories
+ fileChannelManager.close();
Review comment:
we should probably also make close failures silent here by `try {...} catch
(Throwable t) { LOG.warn(...); }` to not interrupt shutdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
