azagrebin commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r294225975
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
##########
@@ -242,7 +242,7 @@ public abstract BulkBlockChannelReader
createBulkBlockChannelReader(
/**
* The manager used for creating/deleting file channels based on config
temp dirs.
*/
- private static class FileChannelManager {
+ public static class FileChannelManager {
Review comment:
I would move it into a separate class because it does not depend on
`IOManager` and now also used completely independently from `IOManager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
