zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297245940
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleDescriptor.java
##########
@@ -67,4 +68,31 @@ default boolean isUnknown() {
* @return the resource id of the producing task executor if the
partition occupies local resources there
*/
Optional<ResourceID> storesLocalResourcesOn();
+
+ /**
+ * Return release types supported by Shuffle Service for this partition.
Review comment:
There might exist two options:
- One `ShuffleService` implementation might provide different
`ShuffleDescriptor` implementations for different partitions with different
release types. Then the previous comment makes sense.
- One `ShuffleService` implementation would only have one kind of
`ShuffleDescriptor` and provide one enum of release types for all the
partitions. Just like atm we only have `NettyShuffleDescriptor` implementation
which provides the same release types for all partitions. So my above comment
suggestion was based on this. The release type is `ShuffleService` global level
suitable for all partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
