zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297252578
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
##########
@@ -51,6 +52,7 @@
* <p>This call triggers release of any resources which are occupied by
the given partition in the external systems
* outside of the producer executor. This is mostly relevant for the
batch jobs and blocking result partitions.
* This method is not called if {@link
ResultPartitionDeploymentDescriptor#isReleasedOnConsumption()} is {@code true}.
+ * The partition has to support the {@link ReleaseType#MANUAL} in
{@link ShuffleDescriptor#getSupportedReleaseTypes()}.
Review comment:
Sorry I have not noticed that this javadoc change was for the method of
`releasePartitionsExternally`, if so I agree it makes sense that this method
implementation is for MANUL release.
Before I thought the new info was added on the class javadoc, that means all
the `ShuffleMaster` implementation must support MANUL release type, so I
pointed out that concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
