zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297525992
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java
##########
@@ -72,13 +72,9 @@
* Tests simple de/serialization with {@link UnknownShuffleDescriptor}.
*/
@Test
- public void testSerializationWithUnknownShuffleDescriptor() throws
Exception {
+ public void testSerializationOfUnknownShuffleDescriptor() throws
Exception {
ShuffleDescriptor shuffleDescriptor = new
UnknownShuffleDescriptor(resultPartitionID);
-
- ResultPartitionDeploymentDescriptor copy =
-
createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor);
-
- ShuffleDescriptor shuffleDescriptorCopy =
copy.getShuffleDescriptor();
+ ShuffleDescriptor shuffleDescriptorCopy =
CommonTestUtils.createCopySerializable(shuffleDescriptor);
Review comment:
this change should be a separate hotfix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services