zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297529541
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactoryTest.java
##########
@@ -65,7 +65,7 @@ private static void testForceConsumptionOnRelease(boolean
forceConsumptionOnRele
ResultPartitionType.BLOCKING,
1,
0),
- NettyShuffleDescriptorBuilder.newBuilder().buildLocal(),
+
NettyShuffleDescriptorBuilder.newBuilder().setBlocking(true).buildLocal(),
Review comment:
might be proper for using `partitionType.isBlocking()` instead of direct
`true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
