zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297532281
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
##########
@@ -103,6 +137,9 @@ public boolean sendScheduleOrUpdateConsumersMessage() {
* by {@link
ShuffleMaster#releasePartitionExternally(ShuffleDescriptor)}
* and {@link ShuffleEnvironment#releasePartitionsLocally(Collection)}.
*
+ * <p>The partition has to support the corresponding {@link
ReleaseType} in
Review comment:
I think it might be better to indicate which value true/false should support
which `releaseType`, otherwise it seems not clear the mapping between this
value and release type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
