tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310553673
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -767,8 +767,7 @@ private void internalRequestSlot(PendingSlotRequest
pendingSlotRequest) throws R
// request can not be fulfilled by any free
slot or pending slot that can be allocated,
// check whether it can be fulfilled by
allocated slots
if (failUnfulfillableRequest &&
!isFulfillableByRegisteredSlots(pendingSlotRequest.getResourceProfile())) {
- throw new
ResourceManagerException("Could not fulfill slot request " +
pendingSlotRequest.getAllocationId() + ". "
- + "Requested resource profile
(" + pendingSlotRequest.getResourceProfile() + ") is unfulfillable.");
+ throw new
UnfulfillableSlotRequestException(pendingSlotRequest);
Review comment:
I think we also need to update the method
`SlotManagerImpl#setFailUnfulfillableRequest` to fail the slots with the proper
exception. Please also add a test because this is apparently not guarded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
