tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310533725
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java
##########
@@ -44,9 +43,8 @@
*
* @param resourceProfile for the to be allocated resource
* @return Collection of {@link ResourceProfile} describing the
allocated slots
- * @throws ResourceManagerException if the resource cannot be allocated
*/
- Collection<ResourceProfile> allocateResource(ResourceProfile
resourceProfile) throws ResourceManagerException;
Review comment:
I'm not sure whether we wanna do this change because it limits the interface
to not be able to fail. In the future we might have implementations which can
check the `resourceProfile` and then fail if it cannot be requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
