pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319464910
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
##########
@@ -50,29 +50,21 @@
//
------------------------------------------------------------------------
- /** The containing task that owns this time service provider. */
- private final AsyncExceptionHandler task;
-
- /** The lock that timers acquire upon triggering. */
- private final Object checkpointLock;
-
/** The executor service that schedules and calls the triggers of this
task. */
private final ScheduledThreadPoolExecutor timerService;
+ private final ScheduledCallbackExecutionContext
callbackExecutionContext;
private final AtomicInteger status;
- public SystemProcessingTimeService(AsyncExceptionHandler
failureHandler, Object checkpointLock) {
- this(failureHandler, checkpointLock, null);
+ @VisibleForTesting
+ SystemProcessingTimeService(ScheduledCallbackExecutionContext
callbackExecutionContext) {
+ this(callbackExecutionContext, null);
}
public SystemProcessingTimeService(
- AsyncExceptionHandler task,
- Object checkpointLock,
- ThreadFactory threadFactory) {
-
- this.task = checkNotNull(task);
- this.checkpointLock = checkNotNull(checkpointLock);
+ ScheduledCallbackExecutionContext callbackExecutionContext,
ThreadFactory threadFactory) {
Review comment:
nit: ditto about wrapped parameters in one line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
