pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319476565
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1139,17 +1138,9 @@ public void triggerCheckpointBarrier(
if (executionState == ExecutionState.RUNNING && invokable !=
null) {
- // build a local closure
- final SafetyNetCloseableRegistry
safetyNetCloseableRegistry =
-
FileSystemSafetyNet.getSafetyNetCloseableRegistryForThread();
-
Runnable runnable = new Runnable() {
@Override
public void run() {
- // set safety net from the task's
context for checkpointing thread
Review comment:
Are you sure we can remove this? What was the purpose of this safety net?
Actually, shouldn't we set it inside the mailbox action? I guess this is set
correctly for the main Task's thread, but this `triggerCheckpointAsync` code
can be executed from a `LegacySourceThread` as well? (because of yielding
execution)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
