pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319470555
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/AbstractInvokable.java
##########
@@ -219,9 +220,12 @@ public ExecutionConfig getExecutionConfig() {
* @param advanceToEndOfEventTime Flag indicating if the source should
inject a {@code MAX_WATERMARK} in the pipeline
* to fire any registered event-time timers
*
- * @return {@code false} if the checkpoint can not be carried out,
{@code true} otherwise
+ * @return future with value of {@code false} if the checkpoint was not
carried out, {@code true} otherwise
*/
- public boolean triggerCheckpoint(CheckpointMetaData checkpointMetaData,
CheckpointOptions checkpointOptions, boolean advanceToEndOfEventTime) throws
Exception {
+ public Future<Boolean> triggerCheckpointAsync(
+ CheckpointMetaData checkpointMetaData,
+ CheckpointOptions checkpointOptions,
+ boolean advanceToEndOfEventTime) {
Review comment:
nit: double indent the parameters or put a new line after `{`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
