zentol commented on a change in pull request #9542: [FLINK-13873][metrics]
Change the column family as tags for influxdb …
URL: https://github.com/apache/flink/pull/9542#discussion_r335978188
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -401,11 +414,18 @@ public void enableActualDelayedWriteRate() {
this.properties.add(RocksDBProperty.ActualDelayedWriteRate.getRocksDBProperty());
}
+ /**
+ * Returns the column family as variable.
+ */
+ public void enableColumnFamilyAsVariable() {
+
this.properties.add(RocksDBProperty.ColumnFamilyAsVariable.getRocksDBProperty());
Review comment:
I would add this as a separate flag with a dedicated getter. That way you
don't have to modify the assertions in the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
