zentol commented on a change in pull request #9542: [FLINK-13873][metrics]
Change the column family as tags for influxdb …
URL: https://github.com/apache/flink/pull/9542#discussion_r335976752
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricMonitor.java
##########
@@ -71,7 +73,9 @@ public RocksDBNativeMetricMonitor(
* @param handle native handle to the column family
*/
void registerColumnFamily(String columnFamilyName, ColumnFamilyHandle
handle) {
- MetricGroup group = metricGroup.addGroup(columnFamilyName);
+
+ Boolean columnFamilyAsVariable =
options.isEnableColumnFaminlyAsVariable();
+ MetricGroup group = columnFamilyAsVariable ?
metricGroup.addGroup(COLUMN_FAMILY_KEY, columnFamilyName) :
metricGroup.addGroup(columnFamilyName);
Review comment:
```suggestion
MetricGroup group = columnFamilyAsVariable
? metricGroup.addGroup(COLUMN_FAMILY_KEY,
columnFamilyName)
: metricGroup.addGroup(columnFamilyName);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
