xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351223125
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
##########
@@ -104,6 +106,7 @@
ResourceID resourceId,
int dataPort,
HardwareDescription hardwareDescription,
+ ResourceProfile defaultSlotResourceProfile,
Review comment:
I'm in favor of naming the class container
`ResourceManagerGatewayRegisterTaskExecutorParams`, so that we avoid to confuse
people with the name of `xxxRegistration` that similar to `WorkerRegistration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
