xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r350094273
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -136,6 +138,20 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
+ /**
+ * Fraction of TaskExecutor resources a default slot should take for
slot requests with unknown resource profiles.
+ */
+ @Documentation.CommonOption(position =
Documentation.CommonOption.POSITION_PARALLELISM_SLOTS)
Review comment:
This position is also used by "parallelism.default", and I think it makes
sense to keep the document of default parallelism and default slot resource
fraction together. So I suggest we rename it to `CommonOption
.POSITION_PARALLELISM_SLOT_FRACTION`. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
